netdev - Re: [PATCH net-next 2/4] net: systemport: use the new fixed PHY helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 19 May 2014 16:31:26 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH net-next 2/4] net: systemport: use the new fixed PHY helpers

2014-05-19 15:04 GMT-07:00 Thomas Petazzoni
<thomas.petazzoni@...e-electrons.com>:
> Dear Florian Fainelli,
>
> On Mon, 19 May 2014 14:52:57 -0700, Florian Fainelli wrote:
>
>> >> +     /* SYSTEMPORT uses the old 'fixed-link' 5-digit property which is
>> >> +      * deprecated, we need to register the fixed PHY using the Ethernet
>> >> +      * MAC node since we do not have a 'fixed-link' subnode.
>> >> +      */
>> >
>> > Actually even if you use the new fixed PHY DT binding, the DT node
>> > linked to the PHY is the Ethernet MAC node. This is because I didn't
>> > want to have a difference between how things are handled between the
>> > old and the new binding.
>>
>> Sure, I agree, and the comment still stands, I am just expressing it
>> that we are not looking for the 'fixed-link' subnode, but the
>> 'fixed-link' 5-digit property here. Would you want me to rephrase
>> that?
>
> What I found misleading in the comment is that you simply to imply that
> because you're not using the new DT binding for fixed-link, the DT node
> that is associated to the PHY is the Ethernet MAC.
>
> The truth is that the DT node associated to the fixed PHY is always the
> Ethernet MAC, regardless of whether you're using the old or the new DT
> binding.

Right, I will respin without this misleading comment and also to
address the formatting issue spotted by Sergei. Thanks!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html