lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 19 May 2014 08:57:25 +0200
From:	Giuseppe CAVALLARO <>
To:	Alexey Khoroshilov <>,
	Srinivas Kandagatla <>
Cc:	"David S. Miller" <>,
	"" <>,
	linux-kernel <>,
Subject: Re: [BUG] might sleep functions in atomic context in stmmac_resume()

Hello Alexey

On 5/17/2014 1:15 AM, Alexey Khoroshilov wrote:
> There are calls to might sleep functions in atomic context in
> stmmac_resume():
> - the first one is clk_prepare_enable(priv->stmmac_clk);
> - the second one is stmmac_hw_setup()
> -> init_dma_desc_rings()
>    -> ´╗┐stmmac_init_rx_buffers()
>      -> __netdev_alloc_skb(GFP_KERNEL)
> What is the purpose of spin_lock_irqsave(&priv->lock, flags) section?
> What does it protect against?

Some part of this driver, especially on PM stuff, has been reworked
time ago.
I have in plan to do further tests and investigations
also to understand and try to solve this kind of issues. I do not
want to see this kind of BUGs. Also I have some other patches on
other pending problem I will submit to be reviewed.
I hope to start doing this task in the incoming days.


> Found by Linux Driver Verification project (
> --
> Alexey Khoroshilov
> Linux Verification Center, ISPRAS
> web:

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists