lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <5379FCD0.2030506@cogentembedded.com> Date: Mon, 19 May 2014 16:45:04 +0400 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Julia Lawall <Julia.Lawall@...6.fr>, "John W. Linville" <linville@...driver.com> CC: kernel-janitors@...r.kernel.org, libertas-dev@...ts.infradead.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/13] libertas: make return of 0 explicit Hello. On 19-05-2014 8:31, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@...6.fr> > Delete unnecessary local variable whose value is always 0 and that hides > the fact that the result is always 0. > A simplified version of the semantic patch that fixes this problem is as > follows: (http://coccinelle.lip6.fr/) > // <smpl> > @r exists@ > local idexpression ret; > expression e; > position p; > @@ > > -ret = 0; > ... when != ret = e > return > - ret > + 0 > ; > // </smpl> > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> > --- > Alternatively, was an error code intended in the bad length case, as is > done in process_brxed_802_11_packet? > drivers/net/wireless/libertas/rx.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > diff --git a/drivers/net/wireless/libertas/rx.c b/drivers/net/wireless/libertas/rx.c > index c7366b0..807c5b8 100644 > --- a/drivers/net/wireless/libertas/rx.c > +++ b/drivers/net/wireless/libertas/rx.c [...] > @@ -154,10 +152,9 @@ int lbs_process_rxed_packet(struct lbs_private *priv, struct sk_buff *skb) > else > netif_rx_ni(skb); > > - ret = 0; > done: > - lbs_deb_leave_args(LBS_DEB_RX, "ret %d", ret); > - return ret; > + lbs_deb_leave_args(LBS_DEB_RX, "ret %d", 0); Why not just "ret 0"? > + return 0; WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists