lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 18 May 2014 21:12:37 -0400 (EDT) From: David Miller <davem@...emloft.net> To: rickard_strandqvist@...ctrumdigital.se Cc: isdn@...ux-pingi.de, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] isdn: hisax: l3dss1.c: Fix for possible null pointer dereference From: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> Date: Sat, 17 May 2014 19:18:21 +0200 > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> ... > @@ -2208,8 +2208,12 @@ static int l3dss1_cmd_global(struct PStack *st, isdn_ctrl *ic) > { free_invoke_id(st, id); > return (-2); > } > - pc->prot.dss1.ll_id = ic->parm.dss1_io.ll_id; /* remember id */ > - pc->prot.dss1.proc = ic->parm.dss1_io.proc; /* and procedure */ > + > + if (pc) > + { > + pc->prot.dss1.ll_id = ic->parm.dss1_io.ll_id; /* remember id */ > + pc->prot.dss1.proc = ic->parm.dss1_io.proc; /* and procedure */ > + } I think rather the intention was to put these pc-> assignments in the timeout > 0 code block. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists