netdev - Re: [PATCH net] ipv6: gro: fix CHECKSUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1400560913.5367.83.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 19 May 2014 21:41:53 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Jerry Chu <hkchu@...gle.com>, netdev <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net] ipv6: gro: fix CHECKSUM_COMPLETE support

On Mon, 2014-05-19 at 18:09 -0700, Eric Dumazet wrote:

> @@ -264,13 +263,10 @@ static struct sk_buff **ipv6_gro_receive(struct sk_buff **head,
>  
>  	NAPI_GRO_CB(skb)->flush |= flush;
>  
> -	csum = skb->csum;
> -	skb_postpull_rcsum(skb, iph, skb_network_header_len(skb));
> +	skb_gro_postpull_rcsum(skb, iph, sizeof(*iph));
>  

sizeof(*iph) doesn't support extension headers. nlen is more appropriate

I'll send a V2



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html