netdev - Re: [PATCH v2] net-tun: restructure tun_do_read for better sleep/wakeup efficiency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1400562668.5367.96.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 19 May 2014 22:11:08 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jason Wang <jasowang@...hat.com>
Cc:	Xi Wang <xii@...gle.com>, "David S. Miller" <davem@...emloft.net>,
	netdev@...r.kernel.org, "Michael S. Tsirkin" <mst@...hat.com>,
	Maxim Krasnyansky <maxk@....qualcomm.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH v2] net-tun: restructure tun_do_read for better
 sleep/wakeup efficiency

On Tue, 2014-05-20 at 12:44 +0800, Jason Wang wrote:
> On 05/19/2014 10:09 PM, Eric Dumazet wrote:

> >
> > About the sk_data_ready() and wake_up_all(), you missed the whole part
> > of the patch I think.
> >
> > Check how sock_def_readable() does everything properly and efficiently,
> > including the async part.
> 
> But this changes (sk_data_ready()) has nothing related to switching to
> use __skb_recv_datagram()
> 

This is totally related.

I think you did not yet understood this patch

Compare wake_up_all() and sk_data_ready() speeds, you'll be surprised.

You should ask to yourself : Why do we use wq_has_sleeper() in
networking stacks ?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html