netdev - Re: [PATCH] net: modify tunnel's name when changing link's name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7O-yr5w6T2PUMXyofyZxmyyaGPSBUN67WTMVdvogmSmmA@mail.gmail.com>
Date:	Tue, 20 May 2014 12:21:56 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Duan Jiong <duanj.fnst@...fujitsu.com>
Cc:	David Miller <davem@...emloft.net>,
	Patrick McHardy <kaber@...sh.net>,
	Eric Dumazet <edumazet@...gle.com>,
	netdev <netdev@...r.kernel.org>,
	stephen hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH] net: modify tunnel's name when changing link's name

On Mon, May 19, 2014 at 10:27 PM, Duan Jiong <duanj.fnst@...fujitsu.com> wrote:
>
> After executing command "ip tunnel add before local 192.168.0.19 mode gre",
> the tunnel "before" and the link "before" are created.
>
> Now if user executes command "ip link set dev before name after",
> the tunnel's name is still "before", but the link's name is
> "after". At last, user executes command "ip tunnel del before",
> and error "No such device" will arise.
>
> ip-tunnel uses ioctl to handle command. It firstly gets link through
> tunnel name, but because link has a different name with tunnel, so
> the error "No such device" arised.
>
> In order to handle this situation, tunnel's name should be modified
> when changing link's name.
>

NACK.

Renaming is just one of the events we miss for tunnels, you obviously
don't want add one netops for each of these events. Instead, we should have
a netdev notifier for every such tunnel devices.

I am working on a patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html