netdev - Re: [PATCH 1/2] mISDN: Use time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1400702866.11896.4.camel@joe-AO725>
Date:	Wed, 21 May 2014 13:07:46 -0700
From:	Joe Perches <joe@...ches.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Manuel Schölling <manuel.schoelling@....de>,
	isdn@...ux-pingi.de, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mISDN: Use time_before()

On Wed, 2014-05-21 at 23:27 +0400, Sergei Shtylyov wrote:
> On 05/21/2014 11:10 PM, Manuel Schölling wrote:
> > To be future-proof and for better readability the time comparisons are modified
> > to use time_before() instead of plain, error-prone math.
> > diff --git a/drivers/isdn/mISDN/l1oip_core.c b/drivers/isdn/mISDN/l1oip_core.c
[]
> > @@ -287,7 +287,7 @@ l1oip_socket_send(struct l1oip *hc, u8 localcodec, u8 channel, u32 chanmask,
> >   	p = frame;
> >
> >   	/* restart timer */
> > -	if ((int)(hc->keep_tl.expires-jiffies) < 5 * HZ) {
> > +	if (time_before(hc->keep_tl.expires - 5 * HZ, jiffies)) {
> 
>     Wouldn't it be clearer this way:
> 
> 	if (time_before(hc->keep_tl.expires, jiffies + 5 * HZ)) {

> >   		del_timer(&hc->keep_tl);
> >   		hc->keep_tl.expires = jiffies + L1OIP_KEEPALIVE * HZ;
> >   		add_timer(&hc->keep_tl);

mod_timer?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html