netdev - Re: [PATCH net v2] ipv6: gro: fix CHECKSUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140521.172016.831231990758100731.davem@davemloft.net>
Date:	Wed, 21 May 2014 17:20:16 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	hkchu@...gle.com, netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH net v2] ipv6: gro: fix CHECKSUM_COMPLETE support

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 19 May 2014 21:56:34 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> When GRE support was added in linux-3.14, CHECKSUM_COMPLETE handling
> broke on GRE+IPv6 because we did not update/use the appropriate csum :
> 
> GRO layer is supposed to use/update NAPI_GRO_CB(skb)->csum instead of
> skb->csum
> 
> Tested using a GRE tunnel and IPv6 traffic. GRO aggregation now happens
> at the first level (ethernet device) instead of being done in gre
> tunnel. Native IPv6+TCP is still properly aggregated.
> 
> Fixes: bf5a755f5e918 ("net-gre-gro: Add GRE support to the GRO stack")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Jerry Chu <hkchu@...gle.com>
> ---
> v2: use nlen instead of sizeof(*iph) to support extension headers

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html