netdev - Re: [PATCH net-next] net: cdc_ncm: fix 64bit division build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140521120733.4cb45333@canb.auug.org.au>
Date:	Wed, 21 May 2014 12:07:33 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Bjørn Mork <bjorn@...k.no>,
	David Miller <davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	Alexey Orishko <alexey.orishko@...il.com>,
	Oliver Neukum <oliver@...kum.org>,
	Enrico Mioso <mrkiko.rs@...il.com>,
	David Laight <David.Laight@...LAB.COM>
Subject: Re: [PATCH net-next] net: cdc_ncm: fix 64bit division build error

Hi all,

On Mon, 19 May 2014 09:21:09 +0200 Bjørn Mork <bjorn@...k.no> wrote:
>
> The upper timer_interval limit is arbitrary and much higher
> than anything usable in the real world.  Reducing it from 15s
> to ~4s to make the timer_interval fit in an u32 does not make
> much difference.  The limit is still outside the practical
> bounds.
> 
> This eliminates the need for a 64bit timer_interval, fixing a
> build error related to 64bit division:
> 
>  drivers/built-in.o: In function `cdc_ncm_get_coalesce':
>  ak8975.c:(.text+0x1ac994): undefined reference to `__aeabi_uldivmod'
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Bjørn Mork <bjorn@...k.no>

I have applied this as a fix patch to linux-next today.
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)