netdev - Re: [PATCH net-next 0/2] bonding: fix enslaving a dev without mtu setting support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 May 2014 15:47:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vfalico@...il.com
Cc:	netdev@...r.kernel.org, j.vosburgh@...il.com, andy@...yhouse.net
Subject: Re: [PATCH net-next 0/2] bonding: fix enslaving a dev without mtu
 setting support

From: Veaceslav Falico <vfalico@...il.com>
Date: Wed, 21 May 2014 17:41:59 +0200

> With the introduction of bond_free_slave() we need to have slave->bond
> populated before calling it, however if the dev_mtu_set(slave, mtu) fails,
> we call bond_free_slave() before actually setting slave->bond, and thus
> we'll panic.
> 
> Fix this by populating slave->bond (and ->dev, it seems appropriate) as
> early as possible.
> 
> Also, remove a harmful check for NULL in bond_get_bond_by_slave(), as it's
> only hiding the real problem and making it harder to debug.
> 
> CC: Jay Vosburgh <j.vosburgh@...il.com>
> CC: Andy Gospodarek <andy@...yhouse.net>
> CC: netdev@...r.kernel.org
> Signed-off-by: Veaceslav Falico <vfalico@...il.com>

Series applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html