netdev - Re: [net] WARNING: CPU: 1 PID: 1 at net/batman-adv/hard-interface.c:92 batadv_is_on_batman

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7Mhd2KYaU8THAd+O4HzQNRLxhpGccvEPOqWJRKAwZbpgQ@mail.gmail.com>
Date:	Wed, 21 May 2014 23:12:36 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Jet Chen <jet.chen@...el.com>
Cc:	Steffen Klassert <steffen.klassert@...unet.com>,
	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [net] WARNING: CPU: 1 PID: 1 at net/batman-adv/hard-interface.c:92
 batadv_is_on_batman_iface()

On Wed, May 21, 2014 at 9:42 PM, Jet Chen <jet.chen@...el.com> wrote:
> Hi Steffen,
>
> 0day kernel testing robot got the below dmesg and the first bad commit is
>
> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
> commit 78ff4be45a4c51d8fb21ad92e4fabb467c6c3eeb
> Author:     Steffen Klassert <steffen.klassert@...unet.com>
> AuthorDate: Mon May 19 11:36:56 2014 +0200
> Commit:     David S. Miller <davem@...emloft.net>
> CommitDate: Wed May 21 02:08:32 2014 -0400
>
>     ip_tunnel: Initialize the fallback device properly
>         We need to initialize the fallback device to have a correct mtu
>     set on this device. Otherwise the mtu is set to null and the device
>     is unusable.
>         Fixes: fd58156e456d ("IPIP: Use ip-tunneling code.")
>     Cc: Pravin B Shelar <pshelar@...ira.com>
>     Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>
>     Signed-off-by: David S. Miller <davem@...emloft.net>
>
> +--------------------------------------------------------------------------------+------------+------------+
> |
> | d8d33c3b8a | 78ff4be45a |
> +--------------------------------------------------------------------------------+------------+------------+
> | boot_successes
> | 60         | 0          |
> | boot_failures
> | 0          | 20         |
> |
> WARNING:CPU:PID:at_net/batman-adv/hard-interface.c:batadv_is_on_batman_iface()
> | 0          | 20         |
> | backtrace:register_netdevice_notifier
> | 0          | 20         |
> | backtrace:batadv_init
> | 0          | 20         |
> | backtrace:kernel_init_freeable
> | 0          | 20         |
> +--------------------------------------------------------------------------------+------------+------------+
>

batman needs to fix:

diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c
index b851cc5..fbda6b5 100644
--- a/net/batman-adv/hard-interface.c
+++ b/net/batman-adv/hard-interface.c
@@ -83,7 +83,7 @@ static bool batadv_is_on_batman_iface(const struct
net_device *net_dev)
                return true;

        /* no more parents..stop recursion */
-       if (net_dev->iflink == net_dev->ifindex)
+       if (net_dev->iflink == 0 || net_dev->iflink == net_dev->ifindex)
                return false;

        /* recurse over the parent device */
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html