netdev - Re: [PATCH] ipv4: initialise the itag variable in __mkroute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQ+bvNGhrEqC3P3DqApjcXM3OUUHqTWJ+iwVmC3f4PguEw@mail.gmail.com>
Date:	Thu, 22 May 2014 09:03:36 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	roy.qing.li@...il.com, Eric Dumazet <eric.dumazet@...il.com>,
	dormando <dormando@...ia.net>,
	"David S. Miller" <davem@...emloft.net>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] ipv4: initialise the itag variable in __mkroute_input

On Thu, May 22, 2014 at 1:36 AM,  <roy.qing.li@...il.com> wrote:
> From: Li RongQing <roy.qing.li@...il.com>
>
> the value of itag is a random value from stack, and may not be initiated by
> fib_validate_source, which called fib_combine_itag if CONFIG_IP_ROUTE_CLASSID
> is not set
>
> This will make the cached dst uncertainty
>
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>

Nice catch. Indeed. I think it's needed for stable.

Acked-by: Alexei Starovoitov <ast@...mgrid.com>

Dormando,
can you check whether your config has CONFIG_IP_ROUTE_CLASSID or not?
The way I'm reading the code, it shouldn't be causing your failures,
but that part
of code is hairy..

> ---
>  net/ipv4/route.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 50e1e0f..4154eb7 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -1526,7 +1526,7 @@ static int __mkroute_input(struct sk_buff *skb,
>         struct in_device *out_dev;
>         unsigned int flags = 0;
>         bool do_cache;
> -       u32 itag;
> +       u32 itag = 0;
>
>         /* get a working reference to the output device */
>         out_dev = __in_dev_get_rcu(FIB_RES_DEV(*res));
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html