netdev - Re: [patch 1/1] lib/test_bpf.c: don't use gcc union shortcut

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 May 2014 11:01:39 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Alexei Starovoitov <ast@...mgrid.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Network Development <netdev@...r.kernel.org>,
	Daniel Borkmann <dborkman@...hat.com>
Subject: Re: [patch 1/1] lib/test_bpf.c: don't use gcc union shortcut

On 05/22/2014 10:58 AM, Andrew Morton wrote:
> On Thu, 22 May 2014 10:36:40 -0700 Alexei Starovoitov <ast@...mgrid.com> wrote:
> 
>> On Thu, May 22, 2014 at 10:16 AM,  <akpm@...ux-foundation.org> wrote:
>>> From: Andrew Morton <akpm@...ux-foundation.org>
>>> Subject: lib/test_bpf.c: don't use gcc union shortcut
>>>
>>> Older gcc's (mine is gcc-4.4.4) make a mess of this.
>>>
>>> lib/test_bpf.c:74: error: unknown field 'insns' specified in initializer
>>> lib/test_bpf.c:75: warning: missing braces around initializer
>>> lib/test_bpf.c:75: warning: (near initialization for 'tests[0].<anonymous>.insns[0]')
>>> lib/test_bpf.c:76: error: extra brace group at end of initializer
>>> lib/test_bpf.c:76: error: (near initialization for 'tests[0].<anonymous>')
>>> lib/test_bpf.c:76: warning: excess elements in union initializer
>>> lib/test_bpf.c:76: warning: (near initialization for 'tests[0].<anonymous>')
>>> lib/test_bpf.c:77: error: extra brace group at end of initializer
>>>
>>> Cc: Alexei Starovoitov <ast@...mgrid.com>
>>> Cc: David S. Miller <davem@...emloft.net>
>>> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>>
>> I didn't know we still want to support such old versions.
>> gcc 4.4 was released in 2009.
> 
> Well, gcc-4.4 fails but I don't know about later versions.
> 
>> What is the official cutoff for gcc ?
> 
> We're really slack about tracking this.  Documentation/Changes says gcc-3.2!

and <linux/compiler-gcc4.h> has some 4.1 and 4.3 testing (and later)
in it.


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html