netdev - Re: [PATCH] net-next:v4: Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140523.150430.1641352816152114168.davem@davemloft.net>
Date:	Fri, 23 May 2014 15:04:30 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sucheta.chakraborty@...gic.com
Cc:	netdev@...r.kernel.org, Dept-HSGLinuxNICDev@...gic.com,
	ben@...adent.org.uk, gregory.v.rose@...el.com,
	linux-net-drivers@...arflare.com, Ariel.Elior@...gic.com,
	amirv@...lanox.com, mkubecek@...e.cz, stephen@...workplumber.org
Subject: Re: [PATCH] net-next:v4: Add support to configure SR-IOV VF
 minimum and maximum Tx rate through ip tool.

From: Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
Date: Thu, 22 May 2014 09:59:05 -0400

> o min_tx_rate puts lower limit on the VF bandwidth. VF is guaranteed
>   to have a bandwidth of at least this value.
>   max_tx_rate puts cap on the VF bandwidth. VF can have a bandwidth
>   of up to this value.
> 
> o A new handler set_vf_rate for attr IFLA_VF_RATE has been introduced
>   which takes 4 arguments:
>   netdev, VF number, min_tx_rate, max_tx_rate
> 
> o ndo_set_vf_rate replaces ndo_set_vf_tx_rate handler.
> 
> o Drivers that currently implement ndo_set_vf_tx_rate should now call
>   ndo_set_vf_rate instead and reject attempt to set a minimum bandwidth
>   greater than 0 for IFLA_VF_TX_RATE when IFLA_VF_RATE is not yet
>   implemented by driver.
> 
> o If user enters only one of either min_tx_rate or max_tx_rate, then,
>   userland should read back the other value from driver and set both
>   for IFLA_VF_RATE.
>   Drivers that have not yet implemented IFLA_VF_RATE should always
>   return min_tx_rate as 0 when read from ip tool.
> 
> o If both IFLA_VF_TX_RATE and IFLA_VF_RATE options are specified, then
>   IFLA_VF_RATE should override.
> 
> o Idea is to have consistent display of rate values to user.
> 
> o Usage example: -
 ...
> Signed-off-by: Sucheta Chakraborty <sucheta.chakraborty@...gic.com>

Looks good, applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html