netdev - Re: [PATCH net] libphy: Add phy specific function to access mmd phy registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGVrzcZJ=5ve1RR=rNX3ovm0yUrv+TNWZGeXNh3MOntpt6yyoA@mail.gmail.com>
Date:	Fri, 23 May 2014 12:18:21 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Vince Bridgers <vbridgers2013@...il.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] libphy: Add phy specific function to access mmd phy registers

2014-05-22 17:02 GMT-07:00 Vince Bridgers <vbridgers2013@...il.com>:
> Hi Florian,
>
> On Thu, May 22, 2014 at 5:32 PM, Florian Fainelli <f.fainelli@...il.com> wrote:
>> Hi,
>>
>> 2014-05-22 15:23 GMT-07:00 Vince Bridgers <vbridgers2013@...il.com>:
>>> libphy was originally written assuming all phy devices support clause 45
>>> access extensions to the mmd registers through the indirection registers
>>> located within the first 16 phy registers. This assumption is not true
>>> in all cases, and one specific example is the Micrel ksz9021 10/100/1000
>>> Mbps phy. Using the stmmac driver, accessing the mmd registers to query
>>> and configure energy efficient Ethernet (EEE) features yielded unexpected
>>> behavior.
>>>
>>> This patch adds mmd access functions to the phy driver that can be
>>> overriden by the phy specific driver if the phy does not support this
>>> mechanism or uses it's own non-standard access mechanism. By default,
>>> the IEEE Compatible clause 45 access mechanism described in clause 22
>>> is used. With this patch, EEE query/configure functions as expected
>>> using the stmmac and the Micrel ksz9021 phy.
>>>
>>> Signed-off-by: Vince Bridgers <vbridgers2013@...il.com>
>>> ---
>>>  drivers/net/phy/micrel.c     |   15 +++++++++++++
>>>  drivers/net/phy/phy.c        |   49 ++++++++++++++++++++++--------------------
>>>  drivers/net/phy/phy_device.c |    6 ++++++
>>>  include/linux/phy.h          |   10 +++++++++
>>>  4 files changed, 57 insertions(+), 23 deletions(-)
>>
>> Could you split that into at least two patches, one that prepares for
>> allowing drivers to implement their own read/write MMD indirect
>> registers function, and another one that does the real implementation
>> for the Micrel PHY driver?
>>
>
> Yes, I'll take care of that and resubmit.

You might also want to check the Documentation/ entries for the PHY
library and make sure that they get updated with the new function sets
as well.

Thanks!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html