netdev - Re: [PATCH 0/3] mdio: Parse DT nodes for auto-probed PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcbC+0uGMc2vVzF1Aw_DyFv+J-mGfQQQ1Xtui0JV-s9dug@mail.gmail.com>
Date:	Fri, 23 May 2014 12:26:00 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Daniel Mack <zonque@...il.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	mugunthanvnm <mugunthanvnm@...com>,
	Matus Ujhelyi <ujhelyi.m@...il.com>
Subject: Re: [PATCH 0/3] mdio: Parse DT nodes for auto-probed PHYs

2014-05-23 12:24 GMT-07:00 Florian Fainelli <f.fainelli@...il.com>:
> Hi Daniel,
>
> 2014-05-22 11:18 GMT-07:00 Daniel Mack <zonque@...il.com>:
>> Hi Florian,
>>
>> On 05/13/2014 06:33 AM, Florian Fainelli wrote:
>>> Le 10/05/2014 09:37, Daniel Mack a écrit :
>>>> Hi Florian,
>>>>
>>>> here's another aproach of solving the issue with auto-probed buses and
>>>> DT device nodes. In short, this patch set introduces a new hook which
>>>> sets the of_node pointer of a phy device to a subnode of the bus, if
>>>> there is any which matches the phy's address. This function is called
>>>> from mdiobus_scan(), and is a no-op for !CONFIG_OF.
>>>>
>>>> Unlike with with the 1st version, dev->of_node is now available in the
>>>> PHY driver's probe() callback already.
>>>>
>>>> Let me know what you think, I'm open to other ideas :)
>>>
>>> I like it so far, I will give this a try on some of my quirky hardware.
>>> Thanks!
>>
>> Did you have a chance yet to test these patches? I can submit a v2 which
>> does the requested of_property_read_u32() change.
>
> I just tested those patches, and they look good. Please resubmit a v2
> with the of_property_read_u32() changes and feel free to add my:
>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

I just found a corner case we need to address. I will follow-up with
an email explaining what is happening.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html