netdev - [PATCH] enic: fix adaptive irq coalescing on 32-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <10713072.kCczZxGWdQ@wuerfel>
Date:	Fri, 23 May 2014 09:51:11 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	netdev@...r.kernel.org
Cc:	Sujith Sankar <ssujith@...co.com>, Neel Patel <neepatel@...co.com>,
	Govindarajulu Varadarajan <_govind@....com>,
	"David S. Miller" <davem@...emloft.net>,
	Christian Benvenuti <benve@...co.com>
Subject: [PATCH] enic: fix adaptive irq coalescing on 32-bit

7c2ce6e60f703 "enic: Add support for adaptive interrupt coalescing"
introduced a 64-bit division that causes a link error on all 32-bit
machines:

drivers/built-in.o: In function `enic_poll_msix':
:(.text+0x54ff00): undefined reference to `__aeabi_uldivmod'

Since we are dividing another 32-bit value and are only interested
in the approximate range here, it should always be safe to limit
the delta to an u32 value.

Signed-off-by: Arnd Bergmann <arnd@...db.de>
----
I haven't seen another report of this bug, just ignore this
mail if it was already fixed.

Also, there may be better ways to solve this.

diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index 0d8995c..ad2fac2 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -1217,7 +1217,7 @@ static void enic_calc_int_moderation(struct enic *enic, struct vnic_rq *rq)
 	 */
 
 	traffic <<= 3;
-	traffic /= delta;
+	traffic /= min_t(u32, delta, UINT_MAX);
 
 	for (index = 0; index < ENIC_MAX_COALESCE_TIMERS; index++)
 		if (traffic < mod_table[index].rx_rate)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html