[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAEP_g=_7fyX1qCi8fC0HyzGGESPQSmYQu=_8YWJGZAecL0hT+w@mail.gmail.com>
Date: Sun, 25 May 2014 10:46:05 -0700
From: Jesse Gross <jesse@...ira.com>
To: Simon Horman <horms@...ge.net.au>
Cc: Thomas Graf <tgraf@...g.ch>, netdev <netdev@...r.kernel.org>,
"dev@...nvswitch.org" <dev@...nvswitch.org>
Subject: Re: [PATCH/RFC net-next] MPLS: Use mpls_features to activate software
MPLS GSO segmentation
On Fri, May 23, 2014 at 7:42 PM, Simon Horman <horms@...ge.net.au> wrote:
> If an MPLS packet requires segmentation then use mpls_features
> to determine if the software implementation should be used.
>
> As no driver advertises MPLS GSO segmentation this will always be
> the case.
>
> I had not noticed that this was necessary before as software MPLS GSO
> segmentation was already being used in my test environment. I believe that
> the reason for that is the skbs in question always had fragments and the
> driver I used does not advertise NETIF_F_FRAGLIST (which seems to be the
> case for most drivers). Thus Thus software segmentation was activated by
> skb_gso_ok().
>
> Thanks to Jesse Gross for prompting me to investigate this.
>
> Cc: Jesse Gross <jesse@...ira.com>
> Signed-off-by: Simon Horman <horms@...ge.net.au>
Acked-by: Jesse Gross <jesse@...ira.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists