netdev - Re: Extend irq_set_affinity_notifier() to use a call chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53832472.7070000@gmail.com>
Date:	Mon, 26 May 2014 14:24:34 +0300
From:	Amir Vadai <amirv.mellanox@...il.com>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	Ben Hutchings <ben@...adent.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>, idos@...lanox.com,
	Yevgeny Petrilin <yevgenyp@...lanox.com>
Subject: Re: Extend irq_set_affinity_notifier() to use a call chain

On 5/26/2014 2:15 PM, Thomas Gleixner wrote:
> On Sun, 25 May 2014, Amir Vadai wrote:
>> In order to do that, I need to add a new irq affinity notification
>> callback (In addition to the existing cpu_rmap notification). For
>> that I would like to extend irq_set_affinity_notifier() to have a
>> notifier call-chain instead of a single notifier callback.
>
> Why? "I would like" is a non argument.
Current implementation enables only one callback to be registered for 
irq affinity change notifications.

cpu_rmap is registered be notified - for RFS purposes.
mlx4_en (and probably other network drivers) needs to be notified too, 
in order to stop the napi polling on the old cpu and move to the new one.
To enable more than 1 notification callbacks, I suggest to use a 
notifier call chain.

Amir

>
> Thanks,
>
> 	tglx
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html