| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAMEtUuyP+F5SxBnaT7a3LgAwcp5MG6knWEsdt1-xdq2pk2gWxQ@mail.gmail.com>
Date: Mon, 26 May 2014 23:02:51 -0700
From: Alexei Starovoitov <ast@...mgrid.com>
To: Daniel Borkmann <dborkman@...hat.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: filter: test fill/spill of all M[] regs
On Mon, May 26, 2014 at 11:17 AM, Daniel Borkmann <dborkman@...hat.com> wrote:
> This test for classic BPF probes stores and load combination
> via X on all 16 registers of the scratch memory store. It
> initially loads integer 100 and passes this value around
> to each register while incrementing it every time, thus we
> expect to have 116 as a result. Might be useful for JIT
> testing.
>
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>
Looks good. The more tests the better.
Acked-by: Alexei Starovoitov <ast@...mgrid.com>
> ---
> lib/test_bpf.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 90 insertions(+)
>
> diff --git a/lib/test_bpf.c b/lib/test_bpf.c
> index af677cb..6be9119 100644
> --- a/lib/test_bpf.c
> +++ b/lib/test_bpf.c
> @@ -1485,6 +1485,96 @@ static struct bpf_test tests[] = {
> { },
> { },
> },
> + { /* Mainly checking JIT here. */
> + "M[]: STX + LDX",
> + .u.insns = {
> + BPF_STMT(BPF_LDX | BPF_IMM, 100),
> + BPF_STMT(BPF_STX, 0),
> + BPF_STMT(BPF_LDX | BPF_MEM, 0),
store and immediate load from the same slot won't catch slot overlap,
but that would be a job for another test.
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 1),
> + BPF_STMT(BPF_LDX | BPF_MEM, 1),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 2),
> + BPF_STMT(BPF_LDX | BPF_MEM, 2),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 3),
> + BPF_STMT(BPF_LDX | BPF_MEM, 3),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 4),
> + BPF_STMT(BPF_LDX | BPF_MEM, 4),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 5),
> + BPF_STMT(BPF_LDX | BPF_MEM, 5),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 6),
> + BPF_STMT(BPF_LDX | BPF_MEM, 6),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 7),
> + BPF_STMT(BPF_LDX | BPF_MEM, 7),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 8),
> + BPF_STMT(BPF_LDX | BPF_MEM, 8),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 9),
> + BPF_STMT(BPF_LDX | BPF_MEM, 9),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 10),
> + BPF_STMT(BPF_LDX | BPF_MEM, 10),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 11),
> + BPF_STMT(BPF_LDX | BPF_MEM, 11),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 12),
> + BPF_STMT(BPF_LDX | BPF_MEM, 12),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 13),
> + BPF_STMT(BPF_LDX | BPF_MEM, 13),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 14),
> + BPF_STMT(BPF_LDX | BPF_MEM, 14),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 15),
> + BPF_STMT(BPF_LDX | BPF_MEM, 15),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_RET | BPF_A, 0),
> + },
> + CLASSIC | FLAG_NO_DATA,
> + { },
> + { { 0, 116 } },
> + },
> };
>
> static struct net_device dev;
> --
> 1.7.11.7
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists