netdev - Re: [PATCH] net: ec_bhf: Add runtime dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140527203059.GA25384@newterm.pl>
Date:	Tue, 27 May 2014 22:30:59 +0200
From:	Darek Marcinkiewicz <reksio@...term.pl>
To:	Jean Delvare <jdelvare@...e.de>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net: ec_bhf: Add runtime dependencies

On Mon, May 26, 2014 at 09:26:14PM +0200, Jean Delvare wrote:
> The ec_bhf driver is specific to the Beckhoff CX5020, an embedded PC
> based on a 32-bit Intel Atom CPU. So we can add a dependency on
> X86_32, with COMPILE_TEST as an alternative to still allow for broader
> build-testing.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Darek Marcinkiewicz <reksio@...term.pl>
> Cc: David S. Miller <davem@...emloft.net>
> ---
>  drivers/net/ethernet/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-3.15-rc7.orig/drivers/net/ethernet/Kconfig	2014-05-26 09:24:00.555619955 +0200
> +++ linux-3.15-rc7/drivers/net/ethernet/Kconfig	2014-05-26 21:01:32.971410992 +0200
> @@ -39,6 +39,7 @@ source "drivers/net/ethernet/cisco/Kconf
>  config CX_ECAT
>  	tristate "Beckhoff CX5020 EtherCAT master support"
>  	depends on PCI
> +	depends on X86_32 || COMPILE_TEST
>  	---help---
>  	  Driver for EtherCAT master module located on CCAT FPGA
>  	  that can be found on Beckhoff CX5020, and possibly other of CX
> 
> 
It makes sense, just one more comment. It is pretty likely that
this driver also works with CX20** family of Beckhoff embedded PCs, which
have 64bit Intel iCore processor. Unfortunately, I haven't yet had a chance
to get my hands on any of those so cannot tell for sure. Maybe allowing
this driver also for x64 would be slightly better option?

-- 
DM
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html