netdev - Re: [PATCH 2/2] net: tilegx: Use helpers from linux/etherdevice.h to check/set MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53863C65.5000404@tilera.com>
Date:	Wed, 28 May 2014 15:43:33 -0400
From:	Chris Metcalf <cmetcalf@...era.com>
To:	Tobias Klauser <tklauser@...tanz.ch>
CC:	<netdev@...r.kernel.org>
Subject: Re: [PATCH 2/2] net: tilegx: Use helpers from linux/etherdevice.h
 to check/set MAC

On 5/27/2014 8:04 AM, Tobias Klauser wrote:
> Use is_valid_ether_addr() to check for a valid MAC address to set on the
> device.  This will also check for the device address being multicast,
> which would have been possible previously.

I don't think having a multicast address here is possible (i.e. as returned
by gxio_mpipe_link_enumerate_mac), and it confuses the actual issue, which
is handling the all-zeroes case in a simulator run.  I'd prefer to see
is_zero_ether_addr() instead.

> Also use ether_addr_copy() instead of a manual memcpy() to set the
> address.
>
> Furthermore, get rid of a redundant assignment of dev->addr_len. This is
> already set by ether_setup() which is called in tile_net_setup().
>
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
> ---
>   drivers/net/ethernet/tile/tilegx.c |   17 ++++++-----------
>   1 file changed, 6 insertions(+), 11 deletions(-)

With the change above,

Acked-by: Chris Metcalf <cmetcalf@...era.com>

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html