lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 May 2014 23:17:00 +0200 From: Paul Bolle <pebolle@...cali.nl> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Tilman Schmidt <tilman@...p.cc>, netdev@...r.kernel.org, isdn4linux@...tserv.isdn4linux.de, "Keil, Karsten" <isdn@...ux-pingi.de>, Jiri Slaby <jslaby@...e.cz> Subject: Re: [PATCH 3/4] tty: allow tty drivers to rename their device nodes On Wed, 2014-05-28 at 14:12 -0700, Greg Kroah-Hartman wrote: > On Wed, May 28, 2014 at 11:06:41PM +0200, Paul Bolle wrote: > > On Wed, 2014-05-28 at 13:56 -0700, Greg Kroah-Hartman wrote: > > > On Wed, May 21, 2014 at 11:39:26PM +0200, Tilman Schmidt wrote: > > > > From: Paul Bolle <pebolle@...cali.nl> > > >> > > > > The device nodes for tty drivers are named using a straightforward > > > > scheme: tty_driver->name with an (increasing) digit appended. But the > > > > capi driver (a part of one of the current ISDN subsystems) requires a > > > > different naming scheme for its "capi_nc" tty_driver: > > > > /dev/capi/0 > > > > /dev/capi/1 > > > > [...] > > > > > > Can't you just use a '!' character to represent the '/' and the tty core > > > will handle it all properly for you without this tty core change needed? > > > > As in: set struct tty_driver.name to "capi!"? > > Yes. Try it and see :) > > If not, let me know, it should "just work". I'll let you know. But chances are v2 will only contain 3 patches! > > > > So add a devnode() callback to struct tty_driver to allow tty drivers > > > > to use a more elaborate naming scheme. And let tty_devnode(), the > > > > devnode() callback for the "tty" class, call that new callback if a tty > > > > driver uses one. This allows the capi driver to add a callback to > > > > enable its scheme. > > > > > > And why the sudden need for this feature, what changed in isdn to > > > warrant this change? > > > > Did you already read the explanation to 4/4? It contains a summary of > > the events that got us in the current situation. > > Sorry, only read patch 3 as it came first :) > > But try the above first, the driver core and udev supports the '!' > character for subdirs for a very long time thanks to some horrid scsi > drivers needing it... Will do. And I'll probably ponder how I managed to miss an easy way out. Thanks for the review! Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists