netdev - Re: [PATCH net-next 0/2] macvlan: fix the problem when mac address changes for passthru mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 May 2014 12:24:05 -0400
From:	Vlad Yasevich <vyasevich@...il.com>
To:	Ding Tianhong <dingtianhong@...wei.com>, kaber@...sh.net,
	davem@...emloft.net
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/2] macvlan: fix the problem when mac address
 changes for passthru mode

On 05/26/2014 08:10 AM, Ding Tianhong wrote:
> Ding Tianhong (2):
>   macvlan: don't change macvlan address alone for passthru mode
>   macvlan: propagate lowerdev mac address changes for passthru mode
> 
>  drivers/net/macvlan.c | 40 +++++++++++++++++++++++++++++++---------
>  1 file changed, 31 insertions(+), 9 deletions(-)
> 

This ends up working kind-of backwards...  A user now has to know
that passthru macvlans he has to change the lower-level mac, but
for all others, changing the macvlan mac is ok and will work...

This also will not work if the passthru macvlan is stacked on
something other the hw (for example: a vlan).

Why not simply propagate the mac address change of the passhtru macvlan
down to the real device?

Thanks
-vlad
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html