netdev - Re: [PATCH 7/7] vxlan: Add support for UDP checksums (v4 TX, v6 zero csums)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+mtBx84sivSJ8P_rFoA=ijT1U1_sd61C+V-JJwMdYyQhbVHig@mail.gmail.com>
Date:	Thu, 29 May 2014 16:38:48 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	Jesse Gross <jesse@...ira.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 7/7] vxlan: Add support for UDP checksums (v4 TX, v6 zero csums)

On Thu, May 29, 2014 at 3:45 PM, Jesse Gross <jesse@...ira.com> wrote:
> On Wed, May 28, 2014 at 9:24 PM, Tom Herbert <therbert@...gle.com> wrote:
>> diff --git a/net/openvswitch/vport-vxlan.c b/net/openvswitch/vport-vxlan.c
>> index a93efa3..0edbd95 100644
>> --- a/net/openvswitch/vport-vxlan.c
>> +++ b/net/openvswitch/vport-vxlan.c
>> @@ -122,7 +122,7 @@ static struct vport *vxlan_tnl_create(const struct vport_parms *parms)
>>         vxlan_port = vxlan_vport(vport);
>>         strncpy(vxlan_port->name, parms->name, IFNAMSIZ);
>>
>> -       vs = vxlan_sock_add(net, htons(dst_port), vxlan_rcv, vport, true, false);
>> +       vs = vxlan_sock_add(net, htons(dst_port), vxlan_rcv, vport, true, 0);
>
> OVS actually already has support for specifying that checksums should
> be calculated/verified plumbed down to the kernel. This is used
> already with GRE (via the TUNNEL_CSUM flag). If we modeled VXLAN
> similarly then it might make the two protocols more similar and give
> us OVS support for free.

I tend to agree, it would be nice if vxlan would be configured like
GRE, use tnl_ptk_info, etc. But, it looks like vxlan is pretty
divergent, so I'd like to decouple doing that from this patch set.

For setting use of csums in vxlan-ovs it should be a matter of adding
IFLA_VXLAN_UDP_CSUM (IFLA_VXLAN_UDP_ZERO_CSUM6_TX for IPv6) flags
argument to vxlan_sock_add. Do you see any issues with that?

Thanks,
Tom
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html