netdev - Re: [PATCH 1/2] ipv6: Fix regression caused by efe4208 in udp_v6_mcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140530.151839.1819689526929476760.davem@davemloft.net>
Date:	Fri, 30 May 2014 15:18:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	sven.wegener@...aler.net, netdev@...r.kernel.org,
	edumazet@...gle.com
Subject: Re: [PATCH 1/2] ipv6: Fix regression caused by efe4208 in
 udp_v6_mcast_next()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 29 May 2014 13:37:35 -0700

> On Thu, 2014-05-29 at 20:27 +0000, Sven Wegener wrote:
>> Commit efe4208 ("ipv6: make lookups simpler and faster") introduced a
>> regression in udp_v6_mcast_next(), resulting in multicast packets not
>> reaching the destination sockets under certain conditions.
>> 
>> The packet's IPv6 addresses are wrongly compared to the IPv6 addresses
>> from the function's socket argument, which indicates the starting point
>> for looping, instead of the loop variable. If the addresses from the
>> first socket do not match the packet's addresses, no socket in the list
>> will match.
>> 
>> Cc: Eric Dumazet <edumazet@...gle.com>
>> Cc: stable@...r.kernel.org # 3.13+
>> Signed-off-by: Sven Wegener <sven.wegener@...aler.net>
>> ---
>>  net/ipv6/udp.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>
> 
> I removed the CC stable@ , as you should not have use it.

I'll apply this to 'net' and queue it up for -stable, thanks.

The next time I merge 'net' into 'net-next' I'll add the second
patch there.

Thanks again.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html