netdev - RE: [PATCH net-next 5/6] be2net: move async cmd processing to a separate routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 May 2014 09:18:34 +0000
From:	Sathya Perla <Sathya.Perla@...lex.Com>
To:	Sathya Perla <Sathya.Perla@...lex.Com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 5/6] be2net: move async cmd processing to a
 separate routine

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> On Behalf Of Sathya Perla
...
> 
>
>  static int be_mcc_compl_process(struct be_adapter *adapter,
>  				struct be_mcc_compl *compl)
>  {
>  	enum mcc_base_status base_status;
>  	enum mcc_addl_status addl_status;
>  	struct be_cmd_resp_hdr *resp_hdr;
> -	u8 opcode = 0, subsystem = 0;
> +	u8 opcode, subsystem;
> 
>  	/* Just swap the status to host endian; mcc tag is opaquely copied
>  	 * from mcc_wrb */
> @@ -148,45 +196,13 @@ static int be_mcc_compl_process(struct be_adapter
> *adapter,
>  	addl_status = addl_status(compl->status);
> 
>  	resp_hdr = be_decode_resp_hdr(compl->tag0, compl->tag1);
> +	opcode = resp_hdr->opcode;
> +	subsystem = resp_hdr->subsystem;
> 
> -	if (resp_hdr) {
> -		opcode = resp_hdr->opcode;
> -		subsystem = resp_hdr->subsystem;
> -	}
> -

I missed a NULL check here. I'll fix this up and re-send the patch set.
Thanks!

> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html