netdev - RE: [PATCH V2 1/2] bnx2x: Adapter not recovery from EEH error injection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87B4DDAD5EAFA041BDC28F314593782D0174AA27@avmb3.qlogic.org>
Date:	Fri, 30 May 2014 12:32:54 +0000
From:	Dmitry Kravkov <Dmitry.Kravkov@...gic.com>
To:	"wenxiong@...ux.vnet.ibm.com" <wenxiong@...ux.vnet.ibm.com>,
	David Miller <davem@...emloft.net>
CC:	Ariel Elior <Ariel.Elior@...gic.com>,
	netdev <netdev@...r.kernel.org>
Subject: RE: [PATCH V2 1/2] bnx2x: Adapter not recovery from EEH error
 injection

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-
> owner@...r.kernel.org] On Behalf Of wenxiong@...ux.vnet.ibm.com
> Sent: Wednesday, May 28, 2014 6:57 PM
> To: David Miller
> Cc: Ariel Elior; netdev; Wen Xiong
> Subject: [PATCH V2 1/2] bnx2x: Adapter not recovery from EEH error
> injection
>
> When injecting EEH error to bnx2x adapter, adapter couldn't be recovery
> and caused recursive EEH errors. The patch fixes the issue.
>
> Signed-off-by: Wen Xiong <wenxiong@...ux.vnet.ibm.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> ===================================================================
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c        2014-05-22
> 18:42:48.000000000 -0500
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c        2014-05-22
> 18:44:36.757765539 -0500
> @@ -13279,8 +13279,8 @@ static int bnx2x_eeh_nic_unload(struct b
>       netdev_reset_tc(bp->dev);
>
>       del_timer_sync(&bp->timer);
> -     cancel_delayed_work(&bp->sp_task);
> -     cancel_delayed_work(&bp->period_task);
> +     cancel_delayed_work_sync(&bp->sp_task);
> +     cancel_delayed_work_sync(&bp->period_task);
>
>       spin_lock_bh(&bp->stats_lock);
>       bp->stats_state = STATS_STATE_DISABLED;
>

Thanks.

Reviewed-by: Dmitry Kravkov <dmitry.kravkov@...gic.com>

> --
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in the
> body of a message to majordomo@...r.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html

________________________________

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html