netdev - Re: [PATCH] sh_eth: use RNC mode for R8A7790

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53889132.7020104@codethink.co.uk>
Date:	Fri, 30 May 2014 15:09:54 +0100
From:	Ben Dooks <ben.dooks@...ethink.co.uk>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	netdev@...r.kernel.org
CC:	linux-kernel@...ethink.co.uk, nobuhiro.iwamatsu.yj@...esas.com,
	magnus.damn@...nsource.se, horms@...ge.net.au
Subject: Re: [PATCH] sh_eth: use RNC mode for R8A7790

On 30/05/14 15:00, Sergei Shtylyov wrote:
> Hello.
> 
> On 05/30/2014 05:56 PM, Ben Dooks wrote:
> 
>    The subject should have "R8A779x".
> 
>> The current behaviour of the sh_eth driver is not to use the RNC bit
>> for the receive ring. This means that every packet recieved is not only
>> generating an IRQ but it also stops the receive ring DMA as well until
>> the driver re-enables it after unloading the packet.
>>
>> This means that a number of the following errors are generated due to
>> the receive packet FIFO overflowing due to nowhere to put packets:
>>
>>     net eth0: Receive FIFO Overflow
>>
>> Setting the RMCR_RNC configuration has so far been tested with an NFS
>> root filesystem and the driver has not failed yet. It is not yet known
>> why this is not set for R8A779x operation (Feedback on this issue or
>> other testing is welcome)
> 
>    I have provided such feedback (and many people provided testing), so
> that the last sentence doesn't make sense anymore.

I suppose it could be removed, it depends on how pedantic people
want to be with the changelogs.


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html