netdev - Re: [PATCH net-next] bridge: fix the unbalanced promiscuous count when add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140530073446.14b87673@nehalam.linuxnetplumber.net>
Date:	Fri, 30 May 2014 07:34:46 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Wang Weidong <wangweidong1@...wei.com>
Cc:	David Miller <davem@...emloft.net>,
	<bridge@...ts.linux-foundation.org>,
	netdev <netdev@...r.kernel.org>, <vyasevic@...hat.com>
Subject: Re: [PATCH net-next] bridge: fix the unbalanced promiscuous count
 when add_if failed

On Thu, 29 May 2014 10:15:30 +0800
Wang Weidong <wangweidong1@...wei.com> wrote:

> As commit 2796d0c648c94("bridge: Automatically manage port
> promiscuous mode."), make the add_if use dev_set_allmulti
> instead of dev_set_promiscuous, so when add_if failed, we
> should do dev_set_allmulti(dev, -1).
> 
> Signed-off-by: Wang Weidong <wangweidong1@...wei.com>

Good catch.
Acked-by: Stephen Hemminger <stephen@...workplumber.org>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html