lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Sun,  1 Jun 2014 10:50:34 +0530
From:	Kiran Kumar Raparthy <>
Cc:	"hyungseoung.yoo" <>,
	Marcel Holtmann <>,
	Gustavo Padovan <>,
	Johan Hedberg <>,
	"David S. Miller" <>,,,
	Android Kernel Team <>,
	John Stultz <>,
	Jaikumar Ganesh <>,
	Kiran Raparthy <>
Subject: [RFC v3] Bluetooth: Keep master role when SCO or eSCO is active

From: "hyungseoung.yoo" <>

Preserve the master role when SCO or eSCO is active
as this improves compatability with lots of
headset and chipset combinations.

This is one of the number of patches from the Android AOSP
common.git tree, which is used on almost all Android devices.
It looks like it would improve support for compatibility with
lot of headset,so I wanted to submit it for review to see
if it should go upstream.

v3: Fixed formatting issues pointed by Sergei

Cc: Marcel Holtmann <>
Cc: Gustavo Padovan <>
Cc: Johan Hedberg <>
Cc: "David S. Miller" <>
Cc: Android Kernel Team <>
Cc: John Stultz <>
Signed-off-by: hyungseoung.yoo <>
Signed-off-by: Jaikumar Ganesh <>
[kiran: Added context to commit message]
Signed-off-by: Kiran Raparthy <>
 net/bluetooth/hci_event.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 15010a2..cfb1355 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1915,6 +1915,14 @@ unlock:
+static inline bool is_sco_active(struct hci_dev *hdev)
+	if (hci_conn_hash_lookup_state(hdev, SCO_LINK, BT_CONNECTED) ||
+	    hci_conn_hash_lookup_state(hdev, ESCO_LINK, BT_CONNECTED))
+		return true;
+	return false;
 static void hci_conn_request_evt(struct hci_dev *hdev, struct sk_buff *skb)
 	struct hci_ev_conn_request *ev = (void *) skb->data;
@@ -1961,7 +1969,9 @@ static void hci_conn_request_evt(struct hci_dev *hdev, struct sk_buff *skb)
 			bacpy(&cp.bdaddr, &ev->bdaddr);
-			if (lmp_rswitch_capable(hdev) && (mask & HCI_LM_MASTER))
+			if (lmp_rswitch_capable(hdev) &&
+			    ((mask & HCI_LM_MASTER) ||
+			    is_sco_active(hdev)))
 				cp.role = 0x00; /* Become master */
 				cp.role = 0x01; /* Remain slave */

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists