netdev - Re: [PATCH] net: filter: fix possible memory leak in __sk_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMEtUuyw3uWp9VVDO+9-+z_GY3iTOi7+d-Y5pwfvr+G00ctQkg@mail.gmail.com>
Date:	Sat, 31 May 2014 23:25:24 -0700
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	Leon Yu <chianglungyu@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Network Development <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Daniel Borkmann <dborkman@...hat.com>
Subject: Re: [PATCH] net: filter: fix possible memory leak in __sk_prepare_filter()

On Sat, May 31, 2014 at 10:37 PM, Leon Yu <chianglungyu@...il.com> wrote:
> __sk_prepare_filter() was reworked in commit bd4cf0ed3 (net: filter:
> rework/optimize internal BPF interpreter's instruction set) so that it should
> have uncharged memory once things went wrong. However that work isn't complete.
> Error is handled only in __sk_migrate_filter() while memory can still leak in
> the error path right after sk_chk_filter().
>
> Signed-off-by: Leon Yu <chianglungyu@...il.com>

Nice catch. Thanks!
kmemleak confirmed the leak.

Acked-by: Alexei Starovoitov <ast@...mgrid.com>
Tested-by: Alexei Starovoitov <ast@...mgrid.com>
Fixes: bd4cf0ed331a ("net: filter: rework/optimize internal BPF
interpreter's instruction set")

Thankfully the fix doesn't have any conflicts with pending net-next patches.

> ---
>  net/core/filter.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 9d79ca0..4aec7b9 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -1559,8 +1559,13 @@ static struct sk_filter *__sk_prepare_filter(struct sk_filter *fp,
>         fp->jited = 0;
>
>         err = sk_chk_filter(fp->insns, fp->len);
> -       if (err)
> +       if (err) {
> +               if (sk != NULL)
> +                       sk_filter_uncharge(sk, fp);
> +               else
> +                       kfree(fp);
>                 return ERR_PTR(err);
> +       }
>
>         /* Probe if we can JIT compile the filter and if so, do
>          * the compilation of the filter.
> --
> 1.9.3
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html