netdev - Re: [PATCH 3.14-stable] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZ+5wkQmabjUhK138akLCVZUY8BQkwhGuX-ssV+UFVn4Ww@mail.gmail.com>
Date:	Sun, 1 Jun 2014 13:52:54 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Wei Yang <weiyang@...ux.vnet.ibm.com>
Cc:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Amir Vadai <amirv@...lanox.com>,
	Jack Morgenstein <jackm@....mellanox.co.il>,
	Or Gerlitz <ogerlitz@...lanox.com>
Subject: Re: [PATCH 3.14-stable] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove_one()

On Sun, Jun 1, 2014 at 12:36 PM, Or Gerlitz <ogerlitz@...lanox.com> wrote:
> On 01/06/2014 12:30, Or Gerlitz wrote:

>> Wait, I recently noticed that on 3.15-rcX if the host is rebooted when the
>> mlx4_core driver is loaded in SRIOV mode, we crash like that, looking on
>> this now, I think there's chance we can relate it to your upstream change
>> befdf89 "net/mlx4_core: Preserve pci_dev_data after __mlx4_remove_one()"


> this seems to fix the crash, will further evaluate and submit patch later today

We ended up with a slightly different fix, let's see it hits well 3.15 and then
you can resume your -stable efforts.

Or.

> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -2629,7 +2629,7 @@ static void __mlx4_remove_one(struct pci_dev *pdev)
>         int               pci_dev_data;
>         int p;
>
> -       if (priv->removed)
> +       if (!priv || priv->removed)
>                 return;
>
>         pci_dev_data = priv->pci_dev_data;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html