netdev - Re: [PATCH v2 net-next repost] MPLS: Use mpls_features to activate software MPLS GSO segmentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140602000800.GD20022@verge.net.au>
Date:	Mon, 2 Jun 2014 09:08:00 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, jesse@...ira.com, tgraf@...g.ch,
	dev@...nvswitch.org
Subject: Re: [PATCH v2 net-next repost] MPLS: Use mpls_features to activate
 software MPLS GSO segmentation

On Fri, May 30, 2014 at 03:43:18PM -0700, David Miller wrote:
> From: Simon Horman <horms@...ge.net.au>
> Date: Fri, 30 May 2014 14:35:19 +0900
> 
> > If an MPLS packet requires segmentation then use mpls_features
> > to determine if the software implementation should be used.
> > 
> > As no driver advertises MPLS GSO segmentation this will always be
> > the case.
> > 
> > I had not noticed that this was necessary before as software MPLS GSO
> > segmentation was already being used in my test environment. I believe that
> > the reason for that is the skbs in question always had fragments and the
> > driver I used does not advertise NETIF_F_FRAGLIST (which seems to be the
> > case for most drivers). Thus software segmentation was activated by
> > skb_gso_ok().
> > 
> > Thanks to Jesse Gross for prompting me to investigate this.
> > 
> > Acked-by: Jesse Gross <jesse@...ira.com>
> > Signed-off-by: Simon Horman <horms@...ge.net.au>
> 
> Just requesting some stylistic changes:
> 
> > +/* If MPLS offload request, verify we are testing hardware MPLS features
> > + * instead of standard features for the netdev.
> > + */
> > +#ifdef CONFIG_NET_MPLS_GSO
> > +static inline netdev_features_t net_mpls_features(struct sk_buff *skb,
> > +	struct net_device *dev, netdev_features_t features)
> 
> Do not use inline in a foo.c file, let the compiler make the decision.
> 
> Also, line up the arguments on the second line correctly, they should
> start exactly at the first column after the openning parenthesis of
> the previous line.
> 
> > +static inline netdev_features_t net_mpls_features(struct sk_buff *skb,
> > +	struct net_device *dev, netdev_features_t features)
> > +{
> > +	return features;
> > +}
> 
> Similarly.

Thanks, I'll fix things up and repost.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html