netdev - Re: [PATCH v2 net-next 0/8] cdc_ncm: fixes and conversion to sysfs API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140602.160219.886445844785145387.davem@davemloft.net>
Date:	Mon, 02 Jun 2014 16:02:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bjorn@...k.no
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	alexey.orishko@...il.com, oliver@...kum.org, mrkiko.rs@...il.com,
	David.Laight@...LAB.COM, larsm17@...il.com, peter@...ge.se,
	gsuarez@...thmicro.com
Subject: Re: [PATCH v2 net-next 0/8] cdc_ncm: fixes and conversion to sysfs
 API

From: Bjørn Mork <bjorn@...k.no>
Date: Fri, 30 May 2014 09:31:02 +0200

> After considering the comments received after the ethtool coalesce
> support was commited, I have ended up concluding that we should
> remove it again, while we can, before it hits a release. The idea
> was not well enough thought through, and all comments received
> pointed to advantages of using a sysfs based API instead.
> 
> This series removes the ethtool coalesce support and replaces it
> with sysfs attributes in a driver specific group under the netdev.
> 
> The first 3 patches are unrelated fixes:
> 
> patch 1: reducing truesize as discussed
> patch 2: fixing a potentional buffer overrun when changing tx_max
> patch 3: prevent framing errors when changing rx_max
> 
> Changes v2:
>  - minor editorial changes to patch 8, as suggested by Peter Stuge

Generally speaking I wouldn't be OK with using sysfs for this stuff,
but you make a very convincing argument for doing so in this specific
case.

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html