netdev - Re: [PATCH v3 2/2] net: hisilicon: add hix5hd2 mac driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140602.161131.783479189097234753.davem@davemloft.net>
Date:	Mon, 02 Jun 2014 16:11:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	zhangfei.gao@...aro.org
Cc:	arnd@...db.de, f.fainelli@...il.com,
	sergei.shtylyov@...entembedded.com, mark.rutland@....com,
	David.Laight@...LAB.COM, eric.dumazet@...il.com,
	haifeng.yan@...aro.org, jchxue@...il.com,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v3 2/2] net: hisilicon: add hix5hd2 mac driver

From: Zhangfei Gao <zhangfei.gao@...aro.org>
Date: Fri, 30 May 2014 17:02:08 +0800

> +			skb = netdev_alloc_skb_ip_align(priv->netdev,
> +				MAC_MAX_FRAME_SIZE);

When a function call, declaration, or definition spans multiple lines,
you must start the arguments on the second and subsequent lines exactly
at the first column after the openning parenthesis.

Please therefore reindent this properly.

> +		addr = dma_map_single(priv->dev, skb->data,
> +					MAC_MAX_FRAME_SIZE, DMA_FROM_DEVICE);

Likewise.

> +		desc->cmd = cpu_to_le32(DESC_VLD_FREE |
> +			(MAC_MAX_FRAME_SIZE - 1) << DESC_BUFF_LEN_OFF);

Likewise.

> +	desc->cmd = cpu_to_le32(DESC_VLD_BUSY | DESC_FL_FULL |
> +			(skb->len & DESC_DATA_MASK) << DESC_DATA_LEN_OFF |
> +			(skb->len & DESC_DATA_MASK) << DESC_BUFF_LEN_OFF);

Likewise.

> +	priv->phy = of_phy_connect(dev, priv->phy_node,
> +		&hix5hd2_adjust_link, 0, priv->phy_mode);

Likewise.

> +static int hix5hd2_mdio_wait_ready(struct mii_bus *bus)
> +{
> +	struct hix5hd2_priv *priv = bus->priv;
> +	void __iomem *base = priv->base;
> +	int i, timeout = 10000;
> +
> +	for (i = 0; readl_relaxed(base + MDIO_SINGLE_CMD) & MDIO_START; i++) {
> +		if (i == timeout)
> +			return -ETIMEDOUT;
> +		udelay(1);
> +	}
> +
> +	return 0;
> +}

10,000 udelay(1)'s is a long time, consider changing to usleep() or
similar.

> +			dma_free_coherent(priv->dev, priv->pool[i].size,
> +					priv->pool[i].desc,
> +					priv->pool[i].phys_addr);

Indentation.

> +		virt_addr = dma_alloc_coherent(dev, size, &phys_addr,
> +				GFP_KERNEL);

Likewise.

> +		netdev_warn(ndev, "using random MAC address %pM\n",
> +			 ndev->dev_addr);

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html