netdev - Re: [PATCH] Force speed and duplex mode setting if link down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140602.164841.1610935068756662568.davem@davemloft.net>
Date:	Mon, 02 Jun 2014 16:48:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	stannous@...ulusnetworks.com
Cc:	netdev@...r.kernel.org, shm@...ulusnetworks.com,
	sfeldma@...ulusnetworks.com
Subject: Re: [PATCH] Force speed and duplex mode setting if link down

From: stannous@...ulusnetworks.com
Date: Mon,  2 Jun 2014 19:07:00 -0400

> +			/* If the interface is down, we'll get an ecmd speed and
> +			   duplex of 0.  This has the effect of defaulting
> +			   the duplex mode to HALF.  This results in an
> +			   error since many of our speeds will not support HALF
> +			   any more.  To prevent this, we need to insist that
> +			   the user provide us with specific duplex mode if
> +			   they haven't already (likely FULL) if both the speed
> +			   and duplex are 0 here.
> +			*/

This comment is not formatted properly for the neworking, the proper layout
is:

	/* Like
	 * this.
	 */

Also, your subject line needs to be adjusted.  After "[PATCH] " you must
specify a subsystem prefix, which here would be something like
"ethtool: ".  This way people reading the commit log headers can see where
in the kernel your changes are happening.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html