netdev - Re: [PATCH 1/7] udp: Generic functions to set checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140601.194942.1014308083943595457.davem@davemloft.net>
Date:	Sun, 01 Jun 2014 19:49:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/7] udp: Generic functions to set checksum

From: Tom Herbert <therbert@...gle.com>
Date: Wed, 28 May 2014 21:23:27 -0700 (PDT)

> Added udp_set_csum and udp6_set_csum functions to set UDP checksums
> in packets. These are for simple UDP packets such as those that might
> be created in UDP tunnels.
> 
> Signed-off-by: Tom Herbert <therbert@...gle.com>
> ---
>  include/net/ip6_checksum.h | 45 +++++++++++++++++++++++++++++++++++++++++++++
>  include/net/udp.h          | 42 ++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 87 insertions(+)
> 
> diff --git a/include/net/ip6_checksum.h b/include/net/ip6_checksum.h
> index 8ac5c21..7382a12 100644
> --- a/include/net/ip6_checksum.h
> +++ b/include/net/ip6_checksum.h
> @@ -82,5 +82,50 @@ static inline void tcp_v6_send_check(struct sock *sk, struct sk_buff *skb)
>  }
>  #endif
>  
> +static inline __sum16 udp_v6_check(int len,
> +				       const struct in6_addr *saddr,
> +				       const struct in6_addr *daddr,
> +				       __wsum base)

Tom, please indent this correctly.  I applied this patch and double checked
and it comes out like this:

static inline __sum16 udp_v6_check(int len,
				       const struct in6_addr *saddr,
				       const struct in6_addr *daddr,
				       __wsum base)

Those arguments must start precisely at the first column after the
openning parenthesis of the function declaration.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html