netdev - Pull request: Fixes for new ethtool RSS commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 02 Jun 2014 01:57:39 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Pull request: Fixes for new ethtool RSS commands

The following changes since commit eb02a272c97b6e25d8e5fcf1ea93923e6f155595:

  driver/net/ethernet/ec_bhf.c: fix sparse warnings (2014-05-14 16:09:33 -0400)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/bwh/net-next.git ethtool-rssh-fixes

for you to fetch changes up to dfe805c14a2018c5a58cfa3921f1897032740501:

  ethtool: Check that reserved fields of struct ethtool_rxfh are 0 (2014-05-19 01:30:30 +0100)

This addresses several problems I previously identified with the new
ETHTOOL_{G,S}RSSH commands:

1. Missing validation of reserved parameters
2. Vague documentation
3. Use of unnamed magic number
4. No consolidation with existing driver operations

I don't currently have access to suitable network hardware, but have
tested these changes with a dummy driver that can support various
combinations of operations and sizes, together with (a) Debian's ethtool
3.13 (b) ethtool 3.14 with the submitted patch to use ETHTOOL_{G,S}RSSH
and minor adjustment for fixes 1 and 3.

Ben.

----------------------------------------------------------------
Ben Hutchings (8):
      ethtool: Return immediately on error in ethtool_copy_validate_indir()
      ethtool: Name the 'no change' value for setting RSS hash key but not indir table
      ethtool: Improve explanation of the two arrays following struct ethtool_rxfh
      ethtool: Expand documentation of ethtool_ops::{get,set}_rxfh()
      ethtool: Disallow ETHTOOL_SRSSH with both indir table and hash key unchanged
      ethtool, be2net: constify array pointer parameters to ethtool_ops::set_rxfh
      ethtool: Replace ethtool_ops::{get,set}_rxfh_indir() with {get,set}_rxfh()
      ethtool: Check that reserved fields of struct ethtool_rxfh are 0

 .../net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c    |  15 +--
 drivers/net/ethernet/broadcom/tg3.c                |   8 +-
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c    |   8 +-
 drivers/net/ethernet/emulex/benet/be_cmds.c        |   2 +-
 drivers/net/ethernet/emulex/benet/be_cmds.h        |   2 +-
 drivers/net/ethernet/emulex/benet/be_ethtool.c     |   3 +-
 drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c |  15 +--
 drivers/net/ethernet/intel/igb/igb_ethtool.c       |   9 +-
 drivers/net/ethernet/mellanox/mlx4/en_ethtool.c    |  10 +-
 drivers/net/ethernet/sfc/ethtool.c                 |  10 +-
 include/linux/ethtool.h                            |  24 ++---
 include/uapi/linux/ethtool.h                       |  25 ++---
 net/core/ethtool.c                                 | 110 +++++++++------------
 13 files changed, 116 insertions(+), 125 deletions(-)

-- 
Ben Hutchings
Any smoothly functioning technology is indistinguishable from a rigged demo.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)