netdev - Re: [PATCH v1 net-next] inetpeer: get rid of ip_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1401711456.3645.182.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 02 Jun 2014 05:17:36 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next] inetpeer: get rid of ip_id_count

On Sun, 2014-06-01 at 19:01 -0700, David Miller wrote:

> I like it.

Great ;)

> 
> I think we should get rid of the 'dst' argument from __ip_select_ident() (and thus
> ip_select_ident() and ip_select_ident_mode()), it is completely unused.

Sure, I did that, and also renamed ip_select_ident_more() to avoid
decrement number of segs in caller in increment it in
__ip_select_ident() again.

> 
> It might even help to do so for ipv6_select_ident(), having it just pass the
> dest addr pointer in instead.

I added a new helper to perform the id reservation in one place only.

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html