netdev - Re: [PATCH] netfilter: nf_conntrack: fix checkpatch errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140603204843.GA13364@macbook.localnet>
Date:	Tue, 3 Jun 2014 21:48:43 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Luca Ellero <luca.ellero@...ckedbrain.com>
Cc:	netfilter@...r.kernel.org, pablo@...filter.org,
	kadlec@...ckhole.kfki.hu, davem@...emloft.net,
	coreteam@...filter.org, netdev@...r.kernel.org
Subject: Re: [PATCH] netfilter: nf_conntrack: fix checkpatch errors

On Tue, Jun 03, 2014 at 04:45:02PM +0200, Luca Ellero wrote:
> Add parenthesis around complex macros
> 
> Signed-off-by: Luca Ellero <luca.ellero@...ckedbrain.com>
> ---
>  net/netfilter/nf_conntrack_pptp.c       |    6 +++---
>  net/netfilter/nf_conntrack_proto_sctp.c |    8 ++++----
>  net/netfilter/nf_conntrack_proto_tcp.c  |    8 ++++----
>  3 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/net/netfilter/nf_conntrack_pptp.c b/net/netfilter/nf_conntrack_pptp.c
> index 825c3e3..a505263 100644
> --- a/net/netfilter/nf_conntrack_pptp.c
> +++ b/net/netfilter/nf_conntrack_pptp.c
> @@ -92,9 +92,9 @@ const char *const pptp_msg_name[] = {
>  EXPORT_SYMBOL(pptp_msg_name);
>  #endif
>  
> -#define SECS *HZ
> -#define MINS * 60 SECS
> -#define HOURS * 60 MINS
> +#define SECS  (*HZ)
> +#define MINS  (*60 SECS)
> +#define HOURS (*60 MINS)

Don't send patches that you obviously didn't even compile test.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html