netdev - Re: [PATCH net-next] bridge: Add bridge ifindex to bridge fdb notify msgs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140602.175922.306402966694605258.davem@davemloft.net>
Date:	Mon, 02 Jun 2014 17:59:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	roopa@...ulusnetworks.com
Cc:	stephen@...workplumber.org, netdev@...r.kernel.org,
	jhs@...atatu.com, wkok@...ulusnetworks.com,
	sfeldma@...ulusnetworks.com, shm@...ulusnetworks.com
Subject: Re: [PATCH net-next] bridge: Add bridge ifindex to bridge fdb
 notify msgs

From: roopa@...ulusnetworks.com
Date: Tue, 27 May 2014 22:39:37 -0700

> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> (This patch was previously posted as RFC at
> http://patchwork.ozlabs.org/patch/352677/)
> 
> This patch adds NDA_MASTER attribute to neighbour attributes enum for
> bridge/master ifindex. And adds NDA_MASTER to bridge fdb notify msgs.
> 
> Today bridge fdb notifications dont contain bridge information.
> Userspace can derive it from the port information in the fdb
> notification. However this is tricky in some scenarious.
> 
> Example, bridge port delete notification comes before bridge fdb
> delete notifications. And we have seen problems in userspace
> when using libnl where, the bridge fdb delete notification handling code
> does not understand which bridge this fdb entry is part of because
> the bridge and port association has already been deleted.
> And these notifications (port membership and fdb) are generated on
> separate rtnl groups.
> 
> Fixing the order of notifications could possibly solve the problem
> for some cases (I can submit a separate patch for that).
> 
> This patch chooses to add NDA_MASTER to bridge fdb notify msgs
> because it not only solves the problem described above, but also helps
> userspace avoid another lookup into link msgs to derive the master index.
> 
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html