netdev - Re: [ovs-dev] [PATCH v4 net-next] MPLS: Use mpls_features to activate software MPLS GSO segmentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140603044948.GA23151@verge.net.au>
Date:	Tue, 3 Jun 2014 13:49:48 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	YAMAMOTO Takashi <yamamoto@...inux.co.jp>
Cc:	eric.dumazet@...il.com, dev@...nvswitch.org,
	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [ovs-dev] [PATCH v4 net-next] MPLS: Use mpls_features to
 activate software MPLS GSO segmentation

On Tue, Jun 03, 2014 at 01:46:11PM +0900, YAMAMOTO Takashi wrote:
> > diff --git a/net/core/dev.c b/net/core/dev.c
> > index 0355ca5..7c063ac 100644
> > --- a/net/core/dev.c
> > +++ b/net/core/dev.c
> > @@ -2498,13 +2498,42 @@ static int dev_gso_segment(struct sk_buff *skb, netdev_features_t features)
> >  	return 0;
> >  }
> >  
> > +/* If MPLS offload request, verify we are testing hardware MPLS features
> > + * instead of standard features for the netdev.
> > + */
> > +#ifdef CONFIG_NET_MPLS_GSO
> > +static netdev_features_t net_mpls_features(struct sk_buff *skb,
> > +					   netdev_features_t features,
> > +					   __be16 type)
> > +{
> > +	int tmp;
> 
> this variable seems no longer used.

Thanks, I will remove it.

> > +
> > +	if (unlikely(type == htons(ETH_P_MPLS_UC) ||
> > +		     type == htons(ETH_P_MPLS_MC)))
> 
> why unlikely?

Because packets are not likely to be MPLS (IMHO).
I'm happy to remove the unlikely() if you like.

> 
> otherwise,
> Acked-by: YAMAMOTO Takashi <yamamoto@...inux.co.jp>
> 
> YAMAMOTO Takashi
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html