netdev - Re: Pull request: Fixes for new ethtool RSS commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140602.230742.1657606763843010424.davem@davemloft.net>
Date:	Mon, 02 Jun 2014 23:07:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ben@...adent.org.uk
Cc:	netdev@...r.kernel.org, VenkatKumar.Duvvuru@...lex.com
Subject: Re: Pull request: Fixes for new ethtool RSS commands

From: Ben Hutchings <ben@...adent.org.uk>
Date: Tue, 03 Jun 2014 02:49:21 +0100

> This addresses several problems I previously identified with the new
> ETHTOOL_{G,S}RSSH commands:
> 
> 1. Missing validation of reserved parameters
> 2. Vague documentation
> 3. Use of unnamed magic number
> 4. No consolidation with existing driver operations
> 
> I don't currently have access to suitable network hardware, but have
> tested these changes with a dummy driver that can support various
> combinations of operations and sizes, together with (a) Debian's ethtool
> 3.13 (b) ethtool 3.14 with the submitted patch to use ETHTOOL_{G,S}RSSH
> and minor adjustment for fixes 1 and 3.
> 
> v2: Update RSS operations in vmxnet3 too

Pulled, will push out once my build test completes ;-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html