netdev - Re: Pull request: Fixes for new ethtool RSS commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140602.172359.1089625839083920695.davem@davemloft.net>
Date:	Mon, 02 Jun 2014 17:23:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ben@...adent.org.uk
Cc:	netdev@...r.kernel.org
Subject: Re: Pull request: Fixes for new ethtool RSS commands

From: David Miller <davem@...emloft.net>
Date: Mon, 02 Jun 2014 17:13:14 -0700 (PDT)

> From: Ben Hutchings <ben@...adent.org.uk>
> Date: Mon, 02 Jun 2014 01:57:39 +0100
> 
>> The following changes since commit eb02a272c97b6e25d8e5fcf1ea93923e6f155595:
>> 
>>   driver/net/ethernet/ec_bhf.c: fix sparse warnings (2014-05-14 16:09:33 -0400)
>> 
>> are available in the git repository at:
>> 
>>   git://git.kernel.org/pub/scm/linux/kernel/git/bwh/net-next.git ethtool-rssh-fixes
>> 
>> for you to fetch changes up to dfe805c14a2018c5a58cfa3921f1897032740501:
>> 
>>   ethtool: Check that reserved fields of struct ethtool_rxfh are 0 (2014-05-19 01:30:30 +0100)
>> 
>> This addresses several problems I previously identified with the new
>> ETHTOOL_{G,S}RSSH commands:
> 
> Pulled into net-next, thanks Ben.

Actually, it looks like you missed some drivers, please fix this up and
resubmit:

drivers/net/vmxnet3/vmxnet3_ethtool.c:631:2: error: unknown field ‘get_rxfh_indir’ specified in initializer
drivers/net/vmxnet3/vmxnet3_ethtool.c:631:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/net/vmxnet3/vmxnet3_ethtool.c:631:2: warning: (near initialization for ‘vmxnet3_ethtool_ops.get_rxfh’) [enabled by default]
drivers/net/vmxnet3/vmxnet3_ethtool.c:632:2: error: unknown field ‘set_rxfh_indir’ specified in initializer
drivers/net/vmxnet3/vmxnet3_ethtool.c:632:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/net/vmxnet3/vmxnet3_ethtool.c:632:2: warning: (near initialization for ‘vmxnet3_ethtool_ops.set_rxfh’) [enabled by default]
make[3]: *** [drivers/net/vmxnet3/vmxnet3_ethtool.o] Error 1
make[2]: *** [drivers/net/vmxnet3] Error 2
make[2]: *** Waiting for unfinished jobs....