netdev - Re: [PATCH] rtlwifi: Add firmware for r8723au

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <538F4540.9080002@lwfinger.net>
Date:	Wed, 04 Jun 2014 11:11:44 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Jes Sorensen <Jes.Sorensen@...hat.com>
CC:	Ben Hutchings <ben@...adent.org.uk>, dwmw2@...radead.org,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] rtlwifi: Add firmware for r8723au

On 06/03/2014 05:14 PM, Ben Hutchings wrote:
> On Sun, 2014-01-19 at 23:35 +0000, Ben Hutchings wrote:
>> On Thu, 2014-01-02 at 18:42 -0600, Larry Finger wrote:
>>> This firmware is for a driver that will soon be submitted to the kernel.
>>> It occurs as data statements in Realtek driver rtl8723A_WiFi_linux_v4.1.3_6044.20121224.
>>>
>>> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
>>> ---
>>>   WHENCE                         |  13 +++++++++++++
>>>   rtlwifi/rtl8723aufw_A.bin      | Bin 0 -> 22172 bytes
>>>   rtlwifi/rtl8723aufw_B.bin      | Bin 0 -> 24118 bytes
>>>   rtlwifi/rtl8723aufw_B_NoBT.bin | Bin 0 -> 19200 bytes
>>>   4 files changed, 13 insertions(+)
>>>   create mode 100644 rtlwifi/rtl8723aufw_A.bin
>>>   create mode 100644 rtlwifi/rtl8723aufw_B.bin
>>>   create mode 100644 rtlwifi/rtl8723aufw_B_NoBT.bin
>> [...]
>>
>> Applied, thanks.
>
> I just noticed that the driver in Linux 3.15 seems to ask for
> rtlwifi/rtl8723aufw.bin and not rtlwifi/rtl8723aufw_A.bin.  You'll need
> to change the filename on one side or the other.

Jes,

As Ben points out, I messed up the firmware names, and one of them needs to be 
changed. Keeping the name "rtlwifi/rtl8723aufw_A.bin" would retain a certain 
amount of symmetry, but is may be easier to retain "rtlwifi/rtl8723aufw.bin" in 
the code. A third option would be to try for one of the names and fall back to 
the other if it fails. What do you think?

In any case, we need additional MODULE_FIRMWARE macros for the other two 
firmware files.

Larry


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html