netdev - Re: [PATCH net] tap: Mark devices of type "tun" as IFF_DONT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <538F7622.2080104@redhat.com>
Date:	Wed, 04 Jun 2014 15:40:18 -0400
From:	Vlad Yasevich <vyasevic@...hat.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH net] tap: Mark devices of type "tun" as IFF_DONT_BRIDGE

On 06/04/2014 02:54 PM, Stephen Hemminger wrote:
> On Wed,  4 Jun 2014 14:06:08 -0400
> Vlad Yasevich <vyasevic@...hat.com> wrote:
> 
>> Tun devices are layer 3 devices and do not work correctly
>> when bridged.  Mark then as IFF_DONT_BRIDGE so that people
>> trying to bridge will get an error.
>>
>> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>
>> ---
>>  drivers/net/tun.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
>> index ee328ba..0161aa3 100644
>> --- a/drivers/net/tun.c
>> +++ b/drivers/net/tun.c
>> @@ -931,6 +931,7 @@ static void tun_net_init(struct net_device *dev)
>>  		/* Zero header length */
>>  		dev->type = ARPHRD_NONE;
>>  		dev->flags = IFF_POINTOPOINT | IFF_NOARP | IFF_MULTICAST;
>> +		dev->priv_flags |= IFF_DONT_BRIDGE;
>>  		dev->tx_queue_len = TUN_READQ_SIZE;  /* We prefer our own queue length */
>>  		break;
>>  
> 
> This should not be necessary since bridge already checks for non-ethernet
> devices.
> 
> 	/* Don't allow bridging non-ethernet like devices */
> 	if ((dev->flags & IFF_LOOPBACK) ||
> 	    dev->type != ARPHRD_ETHER || dev->addr_len != ETH_ALEN ||
> 	    !is_valid_ether_addr(dev->dev_addr))
> 		return -EINVAL;
> 

You are right...  I was shown a snippet of the configure where this
worked, but I never asked which kernel version they were using...

Looks like the above code has been around since 3.2...

Thanks
-vlad
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html