netdev - Re: [PATCH V2 net-next 0/5] amd-xgbe: AMD 10Gb Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140604.143903.1213688714066322891.davem@davemloft.net>
Date:	Wed, 04 Jun 2014 14:39:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	thomas.lendacky@....com
Cc:	netdev@...r.kernel.org, jcm@...hat.com
Subject: Re: [PATCH V2 net-next 0/5] amd-xgbe: AMD 10Gb Ethernet driver

From: David Miller <davem@...emloft.net>
Date: Wed, 04 Jun 2014 14:36:05 -0700 (PDT)

> From: Tom Lendacky <thomas.lendacky@....com>
> Date: Wed, 4 Jun 2014 11:11:31 -0500
> 
>> The following series implements support for the new AMD 10Gb Ethernet
>> driver (amd-xgbe).  It includes the 10Gb Ethernet driver as well as
>> a 10Gb Ethernet PHY driver.
>> 
>> This patch series is based on net-next.
>> 
>> Changes in V2:
>>   - Add phy-mode to the amd-xgbe device bindings
>>   - Obtain the phy-mode from the device tree
>>   - Reference ethernet.txt device bindings for phy-handle and phy-mode
>>   - Connect/disconnect to/from phy during probe/remove, instead of open/close
>>   - Fixes for jumbo packet support / MTU changes
>>   - Formatting changes for debug packet dump
>>   - Free resources in the phylib driver remove function
>>   - Proper NP NULL message during auto-negotiation
> 
> Series applied, thanks.

I had to revert, this breaks the build:

drivers/net/phy/amd-xgbe-phy.c: In function ‘amd_xgbe_phy_probe’:
drivers/net/phy/amd-xgbe-phy.c:1251:2: error: implicit declaration of function ‘of_dev_put’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[3]: *** [drivers/net/phy/amd-xgbe-phy.o] Error 1
make[2]: *** [drivers/net/phy] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2