netdev - Re: [PATCH v2 1/7] udp: Generic functions to set checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140604.151626.2115057173229567050.davem@davemloft.net>
Date:	Wed, 04 Jun 2014 15:16:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	cwang@...pensource.com
Cc:	therbert@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/7] udp: Generic functions to set checksum

From: Cong Wang <cwang@...pensource.com>
Date: Mon, 2 Jun 2014 16:43:04 -0700

> On Sun, Jun 1, 2014 at 9:00 PM, Tom Herbert <therbert@...gle.com> wrote:
>> +
>> +
>> +/* Function to set UDP checksum for an IPv6 UDP packet. This is intended
>> + * for the simple case like when setting the checksum for a UDP tunnel.
>> + */
>> +static inline void udp6_set_csum(struct sock *sk, struct sk_buff *skb,
>> +                                const struct in6_addr *saddr,
>> +                                const struct in6_addr *daddr, int len)
>> +{
> 
> I think this function might be too big to be inlined.
> 
> Ditto for udp_set_csum().

Agreed, Tom please put these into a *.c file and export them.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html